feat(orchestrator): always include execution metrics in sandbox webhook events#2852
Open
AdaAibaby wants to merge 2 commits into
Open
feat(orchestrator): always include execution metrics in sandbox webhook events#2852AdaAibaby wants to merge 2 commits into
AdaAibaby wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the ExecutionMetricsOnWebhooksFlag feature flag, making the inclusion of sandbox execution data in webhook events unconditional during sandbox deletion and pause operations. No issues were identified in these changes, and there is no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the expired
ExecutionMetricsOnWebhooksFlagfeature flag and make execution metrics a permanent part of sandbox webhook payloads. This provides webhook consumers with valuable execution data (started_at, vcpu_count, memory_mb, execution_time) for all sandbox lifecycle events.Motivation
The
ExecutionMetricsOnWebhooksFlagwas introduced as a gradual rollout mechanism to avoid breaking webhook consumers when adding the newexecutionfield to event payloads. The flag's removal deadline (NLT 20250315) has long passed, indicating all consumers have successfully adapted to the new field format.Including execution metrics in webhook events provides significant value:
Changes
ExecutionMetricsOnWebhooksFlagdefinition frompackages/shared/pkg/featureflags/flags.gopackages/orchestrator/pkg/server/sandboxes.go:Impact
DeleteandPauseevents now always includeexecutionfield with:started_at: ISO 8601 timestamp when sandbox startedvcpu_count: Number of vCPUs allocatedmemory_mb: Memory in MB allocatedexecution_time: Milliseconds from start to eventTesting
go build ./packages/shared/... ./packages/orchestrator/...Related Issues
Checklist